summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorIan Abbott <abbotti@mev.co.uk>2026-01-30 19:48:11 +0300
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2026-04-02 16:49:40 +0300
commitae377d6afbd5618500edf0954edfc15aa28b162c (patch)
treea43ca68b76eea42f126dc98891234ff144f24f23
parent63c1983136d784d95054accd31d03006f518e71f (diff)
downloadlinux-ae377d6afbd5618500edf0954edfc15aa28b162c.tar.xz
comedi: s526: Add sanity checks for I/O base address
The "s526" driver uses an admin-supplied configuration option (`it->options[0]`) to configure the I/O port base address of a Sensoray 526 board. It currently allows any base address to be configured but the hardware only supports base addresses (configured by on-board DIP switches) in the range 0 to 0xFFC0 on 64-byte boundaries. Add a sanity check to ensure the device is not configured at an unsupported base address. Signed-off-by: Ian Abbott <abbotti@mev.co.uk> Link: https://patch.msgid.link/20260130170416.49994-47-abbotti@mev.co.uk Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/comedi/drivers/s526.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/comedi/drivers/s526.c b/drivers/comedi/drivers/s526.c
index 9245c679a3c4..dd27c754dea4 100644
--- a/drivers/comedi/drivers/s526.c
+++ b/drivers/comedi/drivers/s526.c
@@ -553,7 +553,8 @@ static int s526_attach(struct comedi_device *dev, struct comedi_devconfig *it)
struct comedi_subdevice *s;
int ret;
- ret = comedi_request_region(dev, it->options[0], 0x40);
+ ret = comedi_check_request_region(dev, it->options[0], 0x40,
+ 0, 0xffc0, 64);
if (ret)
return ret;