diff options
| author | Gabriel Rondon <grondon@gmail.com> | 2026-03-30 21:22:53 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2026-03-31 11:46:39 +0300 |
| commit | adb44bab0ac96391dc9d0e4b3604b65e558f23ec (patch) | |
| tree | 03c98d1f8f70c9ea2af9a913df04cbb9ca24aa7f | |
| parent | 2466b3dd4045cd9f5e3f74803a00284bdaf2e493 (diff) | |
| download | linux-adb44bab0ac96391dc9d0e4b3604b65e558f23ec.tar.xz | |
staging: most: dim2: replace BUG_ON() in configure_channel()
Replace BUG_ON() range check on ch_idx with a return of -EINVAL.
BUG_ON() is deprecated as it crashes the entire kernel on assertion
failure (see Documentation/process/deprecated.rst).
Signed-off-by: Gabriel Rondon <grondon@gmail.com>
Link: https://patch.msgid.link/20260330182255.75241-4-grondon@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/staging/most/dim2/dim2.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/staging/most/dim2/dim2.c b/drivers/staging/most/dim2/dim2.c index b820c3647ce5..0b80f313a266 100644 --- a/drivers/staging/most/dim2/dim2.c +++ b/drivers/staging/most/dim2/dim2.c @@ -457,7 +457,8 @@ static int configure_channel(struct most_interface *most_iface, int ch_idx, int const ch_addr = ch_idx * 2 + 2; struct hdm_channel *const hdm_ch = dev->hch + ch_idx; - BUG_ON(ch_idx < 0 || ch_idx >= DMA_CHANNELS); + if (ch_idx < 0 || ch_idx >= DMA_CHANNELS) + return -EINVAL; if (hdm_ch->is_initialized) return -EPERM; |
