summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAl Viro <viro@zeniv.linux.org.uk>2018-05-15 04:26:32 +0300
committerAl Viro <viro@zeniv.linux.org.uk>2018-05-22 21:28:02 +0300
commita8b75f663ee825ab9d75839482bb12198faee70d (patch)
tree97e5f172d2516a9f8e678ea3297d81a6757b0fd0
parent500e2ab6c39b62c4b16e9964ed8990f091a47ddb (diff)
downloadlinux-a8b75f663ee825ab9d75839482bb12198faee70d.tar.xz
cifs_lookup(): cifs_get_inode_...() never returns 0 with *inode left NULL
not since 2004... Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
-rw-r--r--fs/cifs/dir.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/cifs/dir.c b/fs/cifs/dir.c
index 81ba6e0d88d8..ecbf36c459ea 100644
--- a/fs/cifs/dir.c
+++ b/fs/cifs/dir.c
@@ -812,7 +812,7 @@ cifs_lookup(struct inode *parent_dir_inode, struct dentry *direntry,
parent_dir_inode->i_sb, xid, NULL);
}
- if ((rc == 0) && (newInode != NULL)) {
+ if (rc == 0) {
d_add(direntry, newInode);
/* since paths are not looked up by component - the parent
directories are presumed to be good here */