diff options
| author | Michael Straube <straube.linux@gmail.com> | 2022-04-12 21:57:54 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2022-04-13 09:55:54 +0300 |
| commit | a848981be6e8cb762f2166cdc1daf58783c5c3d1 (patch) | |
| tree | 6a68e7e75b12d96e7e01c2f94aeea5a053e6ac8e | |
| parent | 067b22afad2f26a80b66dd21b72bc6978fe61a9b (diff) | |
| download | linux-a848981be6e8cb762f2166cdc1daf58783c5c3d1.tar.xz | |
staging: r8188eu: clean up long lines in block_write()
Store the address and the data pointer for calls to rtw_writeN() and
rtw_write8() in local variables. This avoids long lines and improves
readability.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20220412185754.8695-7-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/staging/r8188eu/core/rtw_fw.c | 18 |
1 files changed, 14 insertions, 4 deletions
diff --git a/drivers/staging/r8188eu/core/rtw_fw.c b/drivers/staging/r8188eu/core/rtw_fw.c index 1e930799a0b3..8620f3c92b52 100644 --- a/drivers/staging/r8188eu/core/rtw_fw.c +++ b/drivers/staging/r8188eu/core/rtw_fw.c @@ -75,7 +75,8 @@ static int block_write(struct adapter *padapter, u8 *buffer, u32 size) { int ret = _SUCCESS; u32 blocks, block_size, remain; - u32 i, offset; + u32 i, offset, addr; + u8 *data; block_size = MAX_REG_BLOCK_SIZE; @@ -83,7 +84,10 @@ static int block_write(struct adapter *padapter, u8 *buffer, u32 size) remain = size % block_size; for (i = 0; i < blocks; i++) { - ret = rtw_writeN(padapter, (FW_8188E_START_ADDRESS + i * block_size), block_size, (buffer + i * block_size)); + addr = FW_8188E_START_ADDRESS + i * block_size; + data = buffer + i * block_size; + + ret = rtw_writeN(padapter, addr, block_size, data); if (ret == _FAIL) goto exit; } @@ -96,7 +100,10 @@ static int block_write(struct adapter *padapter, u8 *buffer, u32 size) remain = remain % block_size; for (i = 0; i < blocks; i++) { - ret = rtw_writeN(padapter, (FW_8188E_START_ADDRESS + offset + i * block_size), block_size, (buffer + offset + i * block_size)); + addr = FW_8188E_START_ADDRESS + offset + i * block_size; + data = buffer + offset + i * block_size; + + ret = rtw_writeN(padapter, addr, block_size, data); if (ret == _FAIL) goto exit; } @@ -109,7 +116,10 @@ static int block_write(struct adapter *padapter, u8 *buffer, u32 size) blocks = remain; for (i = 0; i < blocks; i++) { - ret = rtw_write8(padapter, (FW_8188E_START_ADDRESS + offset + i), *(buffer + offset + i)); + addr = FW_8188E_START_ADDRESS + offset + i; + data = buffer + offset + i; + + ret = rtw_write8(padapter, addr, *data); if (ret == _FAIL) goto exit; } |