diff options
| author | Lucy Thrun <lucy.thrun@digital-rabbithole.de> | 2025-06-10 20:50:12 +0300 |
|---|---|---|
| committer | Takashi Iwai <tiwai@suse.de> | 2025-06-10 21:24:02 +0300 |
| commit | a409c60111e6bb98fcabab2aeaa069daa9434ca0 (patch) | |
| tree | 1dd575668bfa8a9bd59d9a83aa5d94a7ed2dbe6e | |
| parent | 165bb5b154de4c39c3aa9962f0dd69836d030c19 (diff) | |
| download | linux-a409c60111e6bb98fcabab2aeaa069daa9434ca0.tar.xz | |
ALSA: hda/ca0132: Fix buffer overflow in add_tuning_control
The 'sprintf' call in 'add_tuning_control' may exceed the 44-byte
buffer if either string argument is too long. This triggers a compiler
warning.
Replaced 'sprintf' with 'snprintf' to limit string lengths to prevent
overflow.
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202506100642.95jpuMY1-lkp@intel.com/
Signed-off-by: Lucy Thrun <lucy.thrun@digital-rabbithole.de>
Link: https://patch.msgid.link/20250610175012.918-3-lucy.thrun@digital-rabbithole.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
| -rw-r--r-- | sound/pci/hda/patch_ca0132.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sound/pci/hda/patch_ca0132.c b/sound/pci/hda/patch_ca0132.c index 491d45d652dd..1904964591db 100644 --- a/sound/pci/hda/patch_ca0132.c +++ b/sound/pci/hda/patch_ca0132.c @@ -4410,7 +4410,7 @@ static int add_tuning_control(struct hda_codec *codec, } knew.private_value = HDA_COMPOSE_AMP_VAL(nid, 1, 0, type); - sprintf(namestr, "%s %s Volume", name, dirstr[dir]); + snprintf(namestr, sizeof(namestr), "%s %s Volume", name, dirstr[dir]); return snd_hda_ctl_add(codec, nid, snd_ctl_new1(&knew, codec)); } |