diff options
| author | Fenghua Yu <fenghua.yu@intel.com> | 2021-03-17 05:22:46 +0300 |
|---|---|---|
| committer | Shuah Khan <skhan@linuxfoundation.org> | 2021-04-02 22:57:49 +0300 |
| commit | a3611fbc6e58c147bdd409b356baf15ddf57271e (patch) | |
| tree | 3a76cdd754b567edd4afc006680215078c7b67f1 | |
| parent | b67a7665a917e7305eaa573a474c859fe4c5949e (diff) | |
| download | linux-a3611fbc6e58c147bdd409b356baf15ddf57271e.tar.xz | |
selftests/resctrl: Check for resctrl mount point only if resctrl FS is supported
check_resctrlfs_support() does the following
1. Checks if the platform supports resctrl file system or not by looking
for resctrl in /proc/filesystems
2. Calls opendir() on default resctrl file system path
(i.e. /sys/fs/resctrl)
3. Checks if resctrl file system is mounted or not by looking at
/proc/mounts
Steps 2 and 3 will fail if the platform does not support resctrl file
system. So, there is no need to check for them if step 1 fails.
Fix this by returning immediately if the platform does not support
resctrl file system.
Tested-by: Babu Moger <babu.moger@amd.com>
Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
| -rw-r--r-- | tools/testing/selftests/resctrl/resctrlfs.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/tools/testing/selftests/resctrl/resctrlfs.c b/tools/testing/selftests/resctrl/resctrlfs.c index 6b22a186790a..87195eb78356 100644 --- a/tools/testing/selftests/resctrl/resctrlfs.c +++ b/tools/testing/selftests/resctrl/resctrlfs.c @@ -570,6 +570,9 @@ bool check_resctrlfs_support(void) ksft_print_msg("%s kernel supports resctrl filesystem\n", ret ? "Pass:" : "Fail:"); + if (!ret) + return ret; + dp = opendir(RESCTRL_PATH); ksft_print_msg("%s resctrl mountpoint \"%s\" exists\n", dp ? "Pass:" : "Fail:", RESCTRL_PATH); |