diff options
| author | Filipe Manana <fdmanana@suse.com> | 2025-09-18 14:58:53 +0300 |
|---|---|---|
| committer | David Sterba <dsterba@suse.com> | 2025-09-23 09:49:23 +0300 |
| commit | a35b3dd59bf6fe2bf3c2777bdde623d722caa68c (patch) | |
| tree | 6740ee34b9c81e4cede807ce1bdcc4564e2812c1 | |
| parent | 2d83ed6c6c4607b42ee7927e92a9d2fa31d6f30b (diff) | |
| download | linux-a35b3dd59bf6fe2bf3c2777bdde623d722caa68c.tar.xz | |
btrfs: fix comment about nbytes increase at replay_one_extent()
The comment is wrong about the part where it says a prealloc extent does
not contribute to an inode's nbytes - it does. Only holes don't contribute
and that's what we are checking for, as prealloc extents always have a
disk_bytenr different from 0. So fix the comment and re-organize the code
to not set nbytes twice and set it to the extent item's number of bytes
only if it doesn't represent a hole - in case it's a hole we have already
initialized nbytes to 0 when we declared it.
Reviewed-by: Qu Wenruo <wqu@suse.com>
Signed-off-by: Filipe Manana <fdmanana@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
| -rw-r--r-- | fs/btrfs/tree-log.c | 13 |
1 files changed, 4 insertions, 9 deletions
diff --git a/fs/btrfs/tree-log.c b/fs/btrfs/tree-log.c index 144b12725365..96492080fed8 100644 --- a/fs/btrfs/tree-log.c +++ b/fs/btrfs/tree-log.c @@ -740,15 +740,10 @@ static noinline int replay_one_extent(struct walk_control *wc) if (found_type == BTRFS_FILE_EXTENT_REG || found_type == BTRFS_FILE_EXTENT_PREALLOC) { - nbytes = btrfs_file_extent_num_bytes(wc->log_leaf, item); - extent_end = start + nbytes; - - /* - * We don't add to the inodes nbytes if we are prealloc or a - * hole. - */ - if (btrfs_file_extent_disk_bytenr(wc->log_leaf, item) == 0) - nbytes = 0; + extent_end = start + btrfs_file_extent_num_bytes(wc->log_leaf, item); + /* Holes don't take up space. */ + if (btrfs_file_extent_disk_bytenr(wc->log_leaf, item) != 0) + nbytes = btrfs_file_extent_num_bytes(wc->log_leaf, item); } else if (found_type == BTRFS_FILE_EXTENT_INLINE) { size = btrfs_file_extent_ram_bytes(wc->log_leaf, item); nbytes = btrfs_file_extent_ram_bytes(wc->log_leaf, item); |