diff options
| author | Takashi Iwai <tiwai@suse.de> | 2026-04-14 12:33:34 +0300 |
|---|---|---|
| committer | Takashi Iwai <tiwai@suse.de> | 2026-04-14 13:30:51 +0300 |
| commit | a1ed2ec1c5458b4a99765439cb595dd0e026a352 (patch) | |
| tree | 0c49fd454bd30b00e4d0ff14a80848fb40fa5780 | |
| parent | 46c862f5419e0a86b60b9f9558d247f6084c99f9 (diff) | |
| download | linux-a1ed2ec1c5458b4a99765439cb595dd0e026a352.tar.xz | |
ALSA: usb-audio: Fix missing error handling for get_min_max*()
The recent fix to add the error return value check from get_min_max*()
missed one case in build_audio_procunit() where no error value is set.
This may lead to an uninitialized variable and confuse the caller
(although this wouldn't happen practically because err is set for the
loop of num_ins at the beginning of the funciton).
Fix it by setting "err = 0" properly at the missing case, too.
Fixes: 4f55a85cd4fc ("ALSA: usb-audio: Add error checks against get_min_max*()")
Reported-by: Dan Carpenter <error27@gmail.com>
Closes: https://lore.kernel.org/ad36dGpCBTGsyFr_@stanley.mountain
Link: https://patch.msgid.link/20260414093336.305464-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
| -rw-r--r-- | sound/usb/mixer.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/sound/usb/mixer.c b/sound/usb/mixer.c index d4ef45bf53d7..aa6ea3be100a 100644 --- a/sound/usb/mixer.c +++ b/sound/usb/mixer.c @@ -2687,6 +2687,7 @@ static int build_audio_procunit(struct mixer_build *state, int unitid, cval->max = control_spec[0]; cval->res = 1; cval->initialized = 1; + err = 0; break; } |