diff options
| author | Michael Rubin <matchstick@neverthere.org> | 2025-04-09 01:36:41 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2025-04-15 17:35:50 +0300 |
| commit | 9f0ca07f075017351fde2c9fd575cdf957cef043 (patch) | |
| tree | 3e14d8b8751f106dcc664af9736ec5258cf16024 | |
| parent | 8a3961396b1ca7aeeb35a26087de660f839b2d8e (diff) | |
| download | linux-9f0ca07f075017351fde2c9fd575cdf957cef043.tar.xz | |
staing: gpib: struct typing for gpib_board_config
Using Linux code style for gpib_board_config struct in .h to allow drivers to
migrate.
Adhering to Linux code style.
In general, a pointer, or a struct that has elements that can reasonably be
directly accessed should never be a typedef.
Reported by CheckPatch
WARNING: do not add new typedefs
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250408223659.187109-2-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/staging/gpib/include/gpib_types.h | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/staging/gpib/include/gpib_types.h b/drivers/staging/gpib/include/gpib_types.h index 2d9b9be683f8..9af5fdd1497f 100644 --- a/drivers/staging/gpib/include/gpib_types.h +++ b/drivers/staging/gpib/include/gpib_types.h @@ -24,9 +24,10 @@ typedef struct gpib_interface_struct gpib_interface_t; struct gpib_board; +typedef struct gpib_board_config gpib_board_config_t; /* config parameters that are only used by driver attach functions */ -typedef struct { +struct gpib_board_config { /* firmware blob */ void *init_data; int init_data_length; @@ -49,7 +50,7 @@ typedef struct { char *device_path; /* serial number of hardware to attach */ char *serial_number; -} gpib_board_config_t; +}; struct gpib_interface_struct { /* name of board */ |