diff options
| author | Nirmoy Das <nirmoy.das@intel.com> | 2022-05-11 18:37:46 +0300 |
|---|---|---|
| committer | Matthew Auld <matthew.auld@intel.com> | 2022-05-17 11:34:52 +0300 |
| commit | 9e97c46f832d4669b4e52cde5ad0bd43423504eb (patch) | |
| tree | 0e0ade192c68d3260193b551fe5afcf3b203f714 | |
| parent | 8f6de23184452793e60945a26ac40db435d7798d (diff) | |
| download | linux-9e97c46f832d4669b4e52cde5ad0bd43423504eb.tar.xz | |
drm/i915: gracefully error out on platform with small-bar
Currently we just fatally crash during module load if we encounter
small-BAR configuration on DG2. We have most of the support already, but
we lack the final uAPI bits to tie it all together.
Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
Signed-off-by: Matthew Auld <matthew.auld@intel.com>
[mauld: reword the commit and error message slightly]
Link: https://patchwork.freedesktop.org/patch/msgid/20220511153746.14142-3-nirmoy.das@intel.com
| -rw-r--r-- | drivers/gpu/drm/i915/gt/intel_region_lmem.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/drivers/gpu/drm/i915/gt/intel_region_lmem.c b/drivers/gpu/drm/i915/gt/intel_region_lmem.c index cd105ec10429..e9c12e0d6f59 100644 --- a/drivers/gpu/drm/i915/gt/intel_region_lmem.c +++ b/drivers/gpu/drm/i915/gt/intel_region_lmem.c @@ -111,6 +111,12 @@ static struct intel_memory_region *setup_lmem(struct intel_gt *gt) flat_ccs_base = intel_gt_read_register(gt, XEHPSDV_FLAT_CCS_BASE_ADDR); flat_ccs_base = (flat_ccs_base >> XEHPSDV_CCS_BASE_SHIFT) * SZ_64K; + /* FIXME: Remove this when we have small-bar enabled */ + if (pci_resource_len(pdev, 2) < lmem_size) { + drm_err(&i915->drm, "System requires small-BAR support, which is currently unsupported on this kernel\n"); + return ERR_PTR(-EINVAL); + } + if (GEM_WARN_ON(lmem_size < flat_ccs_base)) return ERR_PTR(-EIO); |