summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorVasily Averin <vvs@virtuozzo.com>2018-11-04 00:11:19 +0300
committerBen Hutchings <ben@decadent.org.uk>2019-02-11 20:53:47 +0300
commit9e871b9a4ddb8a49fe26d7aa8734bf83ab9f07ad (patch)
treec3c25a1fa5cfec6499bda364f2d28b0f41c5aa9c
parent65593437335a599cfb511b80b6ce4124288be49d (diff)
downloadlinux-9e871b9a4ddb8a49fe26d7aa8734bf83ab9f07ad.tar.xz
ext4: add missing brelse() update_backups()'s error path
commit ea0abbb648452cdb6e1734b702b6330a7448fcf8 upstream. Fixes: ac27a0ec112a ("ext4: initial copy of files from ext3") Signed-off-by: Vasily Averin <vvs@virtuozzo.com> Signed-off-by: Theodore Ts'o <tytso@mit.edu> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
-rw-r--r--fs/ext4/resize.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/fs/ext4/resize.c b/fs/ext4/resize.c
index d56aad1ff2ce..b1af45a17a5d 100644
--- a/fs/ext4/resize.c
+++ b/fs/ext4/resize.c
@@ -1093,8 +1093,10 @@ static void update_backups(struct super_block *sb, sector_t blk_off, char *data,
backup_block, backup_block -
ext4_group_first_block_no(sb, group));
BUFFER_TRACE(bh, "get_write_access");
- if ((err = ext4_journal_get_write_access(handle, bh)))
+ if ((err = ext4_journal_get_write_access(handle, bh))) {
+ brelse(bh);
break;
+ }
lock_buffer(bh);
memcpy(bh->b_data, data, size);
if (rest)