diff options
| author | Daniel Mack <zonque@gmail.com> | 2014-07-03 18:51:36 +0400 |
|---|---|---|
| committer | Jiri Slaby <jslaby@suse.cz> | 2014-09-17 18:55:08 +0400 |
| commit | 9e5cee313366d72939f6991ef0a265c8c8da6404 (patch) | |
| tree | e9c34165cdf108720aaa9a4019d80c59afc506e0 | |
| parent | 109275a6d60b1212965ffbb1fcd3d99bb2cefb58 (diff) | |
| download | linux-9e5cee313366d72939f6991ef0a265c8c8da6404.tar.xz | |
ASoC: adau1701: fix adau1701_reg_read()
commit 3ad80b828b2533f37c221e2df155774efd6ed814 upstream.
Fix a long standing bug in the read register routing of adau1701.
The bytes arrive in the buffer in big-endian, so the result has to be
shifted before and-ing the bytes in the loop.
Signed-off-by: Daniel Mack <zonque@gmail.com>
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Mark Brown <broonie@linaro.org>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
| -rw-r--r-- | sound/soc/codecs/adau1701.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/sound/soc/codecs/adau1701.c b/sound/soc/codecs/adau1701.c index adee866f463f..56bfc679f437 100644 --- a/sound/soc/codecs/adau1701.c +++ b/sound/soc/codecs/adau1701.c @@ -230,8 +230,10 @@ static int adau1701_reg_read(void *context, unsigned int reg, *value = 0; - for (i = 0; i < size; i++) - *value |= recv_buf[i] << (i * 8); + for (i = 0; i < size; i++) { + *value <<= 8; + *value |= recv_buf[i]; + } return 0; } |