diff options
| author | Dinghao Liu <dinghao.liu@zju.edu.cn> | 2021-09-03 10:35:43 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2021-09-04 12:50:59 +0300 |
| commit | 9ddbc2a00d7f63fa9748f4278643193dac985f2d (patch) | |
| tree | 799313cbaa20572937bf240773d6c10697b6f2ca | |
| parent | c7c5e6ff533fe1f9afef7d2fa46678987a1335a7 (diff) | |
| download | linux-9ddbc2a00d7f63fa9748f4278643193dac985f2d.tar.xz | |
qlcnic: Remove redundant unlock in qlcnic_pinit_from_rom
Previous commit 68233c583ab4 removes the qlcnic_rom_lock()
in qlcnic_pinit_from_rom(), but remains its corresponding
unlock function, which is odd. I'm not very sure whether the
lock is missing, or the unlock is redundant. This bug is
suggested by a static analysis tool, please advise.
Fixes: 68233c583ab4 ("qlcnic: updated reset sequence")
Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/ethernet/qlogic/qlcnic/qlcnic_init.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_init.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_init.c index 3d61a767a8a3..09f20c794754 100644 --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_init.c +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_init.c @@ -437,7 +437,6 @@ int qlcnic_pinit_from_rom(struct qlcnic_adapter *adapter) QLCWR32(adapter, QLCNIC_CRB_PEG_NET_4 + 0x3c, 1); msleep(20); - qlcnic_rom_unlock(adapter); /* big hammer don't reset CAM block on reset */ QLCWR32(adapter, QLCNIC_ROMUSB_GLB_SW_RESET, 0xfeffffff); |