diff options
| author | Kevin McKinney <klmckinney1@gmail.com> | 2011-10-08 02:50:11 +0400 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2011-10-11 20:18:21 +0400 |
| commit | 9d4f1d0c9d1cf2fc4a73b6fff30aa129b9d1586e (patch) | |
| tree | d2ecf165c4357486b04b8f223eb3f84a44f4fe11 | |
| parent | a8a1cdd6d4daeeb7a8016fbaa2cb79f37b14ea9a (diff) | |
| download | linux-9d4f1d0c9d1cf2fc4a73b6fff30aa129b9d1586e.tar.xz | |
Staging: bcm: Remove assignment in if condition reported by checkpatch.pl
There is a case where an assignment was being done
in an if condition. This patch removes the assignment
from the if condition and places the assignment above
the if statement; thereby improving the readability of
the code.
Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| -rw-r--r-- | drivers/staging/bcm/Misc.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/staging/bcm/Misc.c b/drivers/staging/bcm/Misc.c index 4e900bb6608a..0882e04963a2 100644 --- a/drivers/staging/bcm/Misc.c +++ b/drivers/staging/bcm/Misc.c @@ -1080,7 +1080,8 @@ static int bcm_parse_target_params(PMINI_ADAPTER Adapter) if (!buff) return -ENOMEM; - if ((Adapter->pstargetparams = kmalloc(sizeof(STARGETPARAMS), GFP_KERNEL)) == NULL) { + Adapter->pstargetparams = kmalloc(sizeof(STARGETPARAMS), GFP_KERNEL); + if (Adapter->pstargetparams == NULL) { kfree(buff); return -ENOMEM; } |