diff options
| author | Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com> | 2026-01-02 15:47:32 +0300 |
|---|---|---|
| committer | Nishanth Menon <nm@ti.com> | 2026-01-05 21:40:12 +0300 |
| commit | 9a97b2154ef51dd079bbaf247289e6d82210c03b (patch) | |
| tree | 4973e8387c29e78fe4e263e3224ebd6a88f2ee92 | |
| parent | c076d74383f1ce2c8db4c83c40c714c8751d5d01 (diff) | |
| download | linux-9a97b2154ef51dd079bbaf247289e6d82210c03b.tar.xz | |
soc: ti: knav_dma: Simplify error messages in probe
Simplify the code by using dev_err_probe() and local 'dev' variable.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Link: https://patch.msgid.link/20260102124729.63964-8-krzysztof.kozlowski@oss.qualcomm.com
Signed-off-by: Nishanth Menon <nm@ti.com>
| -rw-r--r-- | drivers/soc/ti/knav_dma.c | 13 |
1 files changed, 5 insertions, 8 deletions
diff --git a/drivers/soc/ti/knav_dma.c b/drivers/soc/ti/knav_dma.c index 93365bac2631..7adf1664da60 100644 --- a/drivers/soc/ti/knav_dma.c +++ b/drivers/soc/ti/knav_dma.c @@ -709,10 +709,8 @@ static int knav_dma_probe(struct platform_device *pdev) struct device_node *child; int ret = 0; - if (!node) { - dev_err(&pdev->dev, "could not find device info\n"); - return -EINVAL; - } + if (!node) + return dev_err_probe(dev, -EINVAL, "could not find device info\n"); kdev = devm_kzalloc(dev, sizeof(struct knav_dma_pool_device), GFP_KERNEL); @@ -725,7 +723,7 @@ static int knav_dma_probe(struct platform_device *pdev) pm_runtime_enable(kdev->dev); ret = pm_runtime_resume_and_get(kdev->dev); if (ret < 0) { - dev_err(kdev->dev, "unable to enable pktdma, err %d\n", ret); + dev_err(dev, "unable to enable pktdma, err %d\n", ret); goto err_pm_disable; } @@ -734,14 +732,13 @@ static int knav_dma_probe(struct platform_device *pdev) ret = dma_init(node, child); if (ret) { of_node_put(child); - dev_err(&pdev->dev, "init failed with %d\n", ret); + dev_err(dev, "init failed with %d\n", ret); break; } } if (list_empty(&kdev->list)) { - dev_err(dev, "no valid dma instance\n"); - ret = -ENODEV; + ret = dev_err_probe(dev, -ENODEV, "no valid dma instance\n"); goto err_put_sync; } |