diff options
| author | Jeff Layton <jlayton@kernel.org> | 2025-02-09 15:31:27 +0300 |
|---|---|---|
| committer | Chuck Lever <chuck.lever@oracle.com> | 2025-03-10 16:11:03 +0300 |
| commit | 999595a651a87f4285c53710b5f600d6a141f526 (patch) | |
| tree | 47f412d961a7f390ac090a26953dd21f52e933c6 | |
| parent | bf36c14972aab13409393690eca73727d9c7fd0c (diff) | |
| download | linux-999595a651a87f4285c53710b5f600d6a141f526.tar.xz | |
nfsd: handle NFS4ERR_BADSLOT on CB_SEQUENCE better
Currently it just restarts the call, without getting a new slot.
Signed-off-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
| -rw-r--r-- | fs/nfsd/nfs4callback.c | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/fs/nfsd/nfs4callback.c b/fs/nfsd/nfs4callback.c index a9e88df17f7a..39c2f7c8c319 100644 --- a/fs/nfsd/nfs4callback.c +++ b/fs/nfsd/nfs4callback.c @@ -1389,6 +1389,13 @@ static bool nfsd4_cb_sequence_done(struct rpc_task *task, struct nfsd4_callback rpc_delay(task, 2 * HZ); return false; case -NFS4ERR_BADSLOT: + /* + * BADSLOT means that the client and server are out of sync + * as to the backchannel parameters. Mark the backchannel faulty + * and restart the RPC, but leak the slot so no one uses it. + */ + nfsd4_mark_cb_fault(cb->cb_clp); + cb->cb_held_slot = -1; goto retry_nowait; case -NFS4ERR_SEQ_MISORDERED: if (session->se_cb_seq_nr[cb->cb_held_slot] != 1) { |