summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorZheyu Ma <zheyuma97@gmail.com>2022-02-28 17:54:15 +0300
committerMartin K. Petersen <martin.petersen@oracle.com>2022-03-02 07:56:28 +0300
commit98cdcd6c6b4a3abacc65dd7ec66a230a5dffc3f8 (patch)
treefbc86a9cabff13aa260a00a4c95c2dc3b9dde114
parent69af1c9577aae2149f79be6f485609250fdfb0ad (diff)
downloadlinux-98cdcd6c6b4a3abacc65dd7ec66a230a5dffc3f8.tar.xz
scsi: wd719x: Return proper error code when dma_set_mask() fails
During the process of driver probing, the probe function should return < 0 for failure, otherwise the kernel will treat value >= 0 as success. Set 'err' to the error value returned by dma_set_mask() in case of failure. Link: https://lore.kernel.org/r/1646060055-11361-1-git-send-email-zheyuma97@gmail.com Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com> Signed-off-by: Zheyu Ma <zheyuma97@gmail.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
-rw-r--r--drivers/scsi/wd719x.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/scsi/wd719x.c b/drivers/scsi/wd719x.c
index f341b79d8036..ff1b22077251 100644
--- a/drivers/scsi/wd719x.c
+++ b/drivers/scsi/wd719x.c
@@ -904,7 +904,8 @@ static int wd719x_pci_probe(struct pci_dev *pdev, const struct pci_device_id *d)
if (err)
goto fail;
- if (dma_set_mask(&pdev->dev, DMA_BIT_MASK(32))) {
+ err = dma_set_mask(&pdev->dev, DMA_BIT_MASK(32));
+ if (err) {
dev_warn(&pdev->dev, "Unable to set 32-bit DMA mask\n");
goto disable_device;
}