diff options
| author | Dan Carpenter <dan.carpenter@linaro.org> | 2025-11-28 10:17:49 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2026-01-16 18:31:31 +0300 |
| commit | 96118565d24e7691e423d73be224b3a3fffc4680 (patch) | |
| tree | da0eb0253d773fa7c9d2f38282c9efa9d8930f71 | |
| parent | 327e987e5166a407554e8cccba8e5f8d51f1c868 (diff) | |
| download | linux-96118565d24e7691e423d73be224b3a3fffc4680.tar.xz | |
gpib: Fix error code in ibonline()
This accidentally returns 1 on error, but it should return negative
error codes.
Fixes: 9dde4559e939 ("staging: gpib: Add GPIB common core driver")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://patch.msgid.link/aSlMnaT1M104NJb2@stanley.mountain
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/gpib/common/iblib.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/gpib/common/iblib.c b/drivers/gpib/common/iblib.c index 7cbb6a467177..b672dd6aad25 100644 --- a/drivers/gpib/common/iblib.c +++ b/drivers/gpib/common/iblib.c @@ -227,11 +227,10 @@ int ibonline(struct gpib_board *board) #ifndef CONFIG_NIOS2 board->autospoll_task = kthread_run(&autospoll_thread, board, "gpib%d_autospoll_kthread", board->minor); - retval = IS_ERR(board->autospoll_task); - if (retval) { + if (IS_ERR(board->autospoll_task)) { dev_err(board->gpib_dev, "failed to create autospoll thread\n"); board->interface->detach(board); - return retval; + return PTR_ERR(board->autospoll_task); } #endif board->online = 1; |