diff options
| author | Dan Carpenter <dan.carpenter@linaro.org> | 2025-10-24 09:19:21 +0300 |
|---|---|---|
| committer | Bartosz Golaszewski <bartosz.golaszewski@linaro.org> | 2025-10-27 12:19:17 +0300 |
| commit | 9452252dff94ff2cbcd33d3418c2b95ff74bdba5 (patch) | |
| tree | 10d36fe6887c981517f879212c078cba9f0a3138 | |
| parent | 96fbc8050d0f8d208dfd807aa0137082f1e07ff2 (diff) | |
| download | linux-9452252dff94ff2cbcd33d3418c2b95ff74bdba5.tar.xz | |
gpio: qixis-fpga: Fix a NULL vs IS_ERR() bug in probe()
The devm_platform_ioremap_resource() function doesn't return NULL, it
returns error pointers. Fix the checking to match.
Fixes: e88500247dc3 ("gpio: add QIXIS FPGA GPIO controller")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Michael Walle <mwalle@kernel.org>
Link: https://lore.kernel.org/r/aPsaaf0h343Ba7c1@stanley.mountain
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
| -rw-r--r-- | drivers/gpio/gpio-qixis-fpga.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/gpio/gpio-qixis-fpga.c b/drivers/gpio/gpio-qixis-fpga.c index 54c2c76822d5..6e67f43ac0bd 100644 --- a/drivers/gpio/gpio-qixis-fpga.c +++ b/drivers/gpio/gpio-qixis-fpga.c @@ -56,8 +56,8 @@ static int qixis_cpld_gpio_probe(struct platform_device *pdev) * create our own from the MMIO space. */ reg = devm_platform_ioremap_resource(pdev, 0); - if (!reg) - return -ENODEV; + if (IS_ERR(reg)) + return PTR_ERR(reg); regmap = devm_regmap_init_mmio(&pdev->dev, reg, ®map_config_8r_8v); if (!regmap) |