diff options
| author | Ivan Orlov <ivan.orlov0322@gmail.com> | 2024-08-15 03:04:31 +0300 |
|---|---|---|
| committer | Kees Cook <kees@kernel.org> | 2024-08-15 19:24:55 +0300 |
| commit | 92e9bac18124682c4b99ede9ee3bcdd68f121e92 (patch) | |
| tree | 2ff0778c0fc107fb57c8400e4f03d0dad4771585 | |
| parent | f32e90c0688a3d1f8079ac18ed39b752d22e92bd (diff) | |
| download | linux-92e9bac18124682c4b99ede9ee3bcdd68f121e92.tar.xz | |
kunit/overflow: Fix UB in overflow_allocation_test
The 'device_name' array doesn't exist out of the
'overflow_allocation_test' function scope. However, it is being used as
a driver name when calling 'kunit_driver_create' from
'kunit_device_register'. It produces the kernel panic with KASAN
enabled.
Since this variable is used in one place only, remove it and pass the
device name into kunit_device_register directly as an ascii string.
Signed-off-by: Ivan Orlov <ivan.orlov0322@gmail.com>
Reviewed-by: David Gow <davidgow@google.com>
Link: https://lore.kernel.org/r/20240815000431.401869-1-ivan.orlov0322@gmail.com
Signed-off-by: Kees Cook <kees@kernel.org>
| -rw-r--r-- | lib/overflow_kunit.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/lib/overflow_kunit.c b/lib/overflow_kunit.c index f314a0c15a6d..2abc78367dd1 100644 --- a/lib/overflow_kunit.c +++ b/lib/overflow_kunit.c @@ -668,7 +668,6 @@ DEFINE_TEST_ALLOC(devm_kzalloc, devm_kfree, 1, 1, 0); static void overflow_allocation_test(struct kunit *test) { - const char device_name[] = "overflow-test"; struct device *dev; int count = 0; @@ -678,7 +677,7 @@ static void overflow_allocation_test(struct kunit *test) } while (0) /* Create dummy device for devm_kmalloc()-family tests. */ - dev = kunit_device_register(test, device_name); + dev = kunit_device_register(test, "overflow-test"); KUNIT_ASSERT_FALSE_MSG(test, IS_ERR(dev), "Cannot register test device\n"); |