diff options
| author | Christophe Leroy <christophe.leroy@c-s.fr> | 2017-12-18 13:08:31 +0300 |
|---|---|---|
| committer | Linus Walleij <linus.walleij@linaro.org> | 2017-12-20 12:33:21 +0300 |
| commit | 9295c01253b4eda5dc0b5a5b2e0fd321fe57010c (patch) | |
| tree | 779f856770f7759d7f15bd29c9717e44208be691 | |
| parent | 7fda9100bb8258bbdff90f3db5079d28eb9b0013 (diff) | |
| download | linux-9295c01253b4eda5dc0b5a5b2e0fd321fe57010c.tar.xz | |
gpio: sysfs: correct error handling on 'value' attribute read.
'value' attribute is supposed to only return 0 or 1 according to
the documentation.
With today's implementation, if gpiod_get_value_cansleep() fails
the printed 'value' is a negative value.
This patch ensures that an error is returned on read instead.
Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
| -rw-r--r-- | drivers/gpio/gpiolib-sysfs.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/drivers/gpio/gpiolib-sysfs.c b/drivers/gpio/gpiolib-sysfs.c index 3b2465bbd5e7..ef34b8f56bd1 100644 --- a/drivers/gpio/gpiolib-sysfs.c +++ b/drivers/gpio/gpiolib-sysfs.c @@ -106,8 +106,12 @@ static ssize_t value_show(struct device *dev, mutex_lock(&data->mutex); - status = sprintf(buf, "%d\n", gpiod_get_value_cansleep(desc)); + status = gpiod_get_value_cansleep(desc); + if (status < 0) + goto err; + status = sprintf(buf, "%d\n", status); +err: mutex_unlock(&data->mutex); return status; |