summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorEric Biggers <ebiggers@kernel.org>2026-02-06 07:59:32 +0300
committerMikulas Patocka <mpatocka@redhat.com>2026-03-09 17:12:44 +0300
commit8ef45923fdcb7ec44e3a965bcbf41723e20814e4 (patch)
treed29aca13e102cf65338d4196bf416db9428a823e
parent41208f3707e97976f3b1b7c36c4c094e05e5cf1d (diff)
downloadlinux-8ef45923fdcb7ec44e3a965bcbf41723e20814e4.tar.xz
dm-verity-fec: simplify computation of rsb
To compute 'rsb', verity_fec_decode() divides 'offset' by 'v->fec->region_blocks << v->data_dev_block_bits', then subtracts the quotient times that divisor. That's simply the long way to do a modulo operation, i.e. a - b * floor(a / b) instead of just a % b. Use div64_u64_rem() to get the remainder more concisely. Signed-off-by: Eric Biggers <ebiggers@kernel.org> Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
-rw-r--r--drivers/md/dm-verity-fec.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/md/dm-verity-fec.c b/drivers/md/dm-verity-fec.c
index d132fd5dc7b4..d2c55896e6f7 100644
--- a/drivers/md/dm-verity-fec.c
+++ b/drivers/md/dm-verity-fec.c
@@ -377,7 +377,7 @@ int verity_fec_decode(struct dm_verity *v, struct dm_verity_io *io,
{
int r;
struct dm_verity_fec_io *fio;
- u64 offset, res, rsb;
+ u64 offset, rsb;
if (!verity_fec_is_enabled(v))
return -EOPNOTSUPP;
@@ -405,13 +405,13 @@ int verity_fec_decode(struct dm_verity *v, struct dm_verity_io *io,
*/
offset = block << v->data_dev_block_bits;
- res = div64_u64(offset, v->fec->region_blocks << v->data_dev_block_bits);
/*
* The base RS block we can feed to the interleaver to find out all
* blocks required for decoding.
*/
- rsb = offset - res * (v->fec->region_blocks << v->data_dev_block_bits);
+ div64_u64_rem(offset, v->fec->region_blocks << v->data_dev_block_bits,
+ &rsb);
/*
* Locating erasures is slow, so attempt to recover the block without