diff options
| author | Íñigo Huguet <ihuguet@redhat.com> | 2022-01-13 12:42:53 +0300 |
|---|---|---|
| committer | Kalle Valo <kvalo@kernel.org> | 2022-01-28 18:57:46 +0300 |
| commit | 89e4a00ff3c0352fff27351058a25b39db30ede2 (patch) | |
| tree | 1192b37c59f83233af25e01cd1897187c47252d7 | |
| parent | e0925375b2c658505fb8a04dcadc12f8d59574fd (diff) | |
| download | linux-89e4a00ff3c0352fff27351058a25b39db30ede2.tar.xz | |
rtw89: fix maybe uninitialized `qempty` variable
Call to dle_dfi_qempty might fail, leaving qempty.qempty untouched, which
is latter used to control the for loop. If that happens, it's not
initialized anywhere.
Initialize it so the loop doesn't iterate unless it's modified by the
call to dle_dfi_qempty.
Signed-off-by: Íñigo Huguet <ihuguet@redhat.com>
Acked-by: Ping-Ke Shih <pkshih@realtek.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/20220113094253.73370-1-ihuguet@redhat.com
| -rw-r--r-- | drivers/net/wireless/realtek/rtw89/mac.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/net/wireless/realtek/rtw89/mac.c b/drivers/net/wireless/realtek/rtw89/mac.c index 0a006f3c3742..2e95d9007c41 100644 --- a/drivers/net/wireless/realtek/rtw89/mac.c +++ b/drivers/net/wireless/realtek/rtw89/mac.c @@ -172,6 +172,7 @@ static void rtw89_mac_dump_qta_lost(struct rtw89_dev *rtwdev) qempty.dle_type = DLE_CTRL_TYPE_PLE; qempty.grpsel = 0; + qempty.qempty = ~(u32)0; ret = dle_dfi_qempty(rtwdev, &qempty); if (ret) rtw89_warn(rtwdev, "%s: query DLE fail\n", __func__); |