diff options
| author | Billy Tsai <billy_tsai@aspeedtech.com> | 2021-11-24 12:43:48 +0300 |
|---|---|---|
| committer | Marc Zyngier <maz@kernel.org> | 2021-11-25 19:50:44 +0300 |
| commit | 8958389681b929fcc7301e7dc5f0da12e4a256a0 (patch) | |
| tree | b4a6f589fba9d663adee08cf4781663cfbf62127 | |
| parent | d0a553502efd545c1ce3fd08fc4d423f8e4ac3d6 (diff) | |
| download | linux-8958389681b929fcc7301e7dc5f0da12e4a256a0.tar.xz | |
irqchip/aspeed-scu: Replace update_bits with write_bits.
The interrupt status bits are cleared by writing 1, we should force a
write to clear the interrupt without checking if the value has changed.
Fixes: 04f605906ff0 ("irqchip: Add Aspeed SCU interrupt controller")
Signed-off-by: Billy Tsai <billy_tsai@aspeedtech.com>
Reviewed-by: Joel Stanley <joel@jms.id.au>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20211124094348.11621-1-billy_tsai@aspeedtech.com
Cc: stable@vger.kernel.org
| -rw-r--r-- | drivers/irqchip/irq-aspeed-scu-ic.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/irqchip/irq-aspeed-scu-ic.c b/drivers/irqchip/irq-aspeed-scu-ic.c index f3c6855a4cef..18b77c3e6db4 100644 --- a/drivers/irqchip/irq-aspeed-scu-ic.c +++ b/drivers/irqchip/irq-aspeed-scu-ic.c @@ -76,8 +76,8 @@ static void aspeed_scu_ic_irq_handler(struct irq_desc *desc) generic_handle_domain_irq(scu_ic->irq_domain, bit - scu_ic->irq_shift); - regmap_update_bits(scu_ic->scu, scu_ic->reg, mask, - BIT(bit + ASPEED_SCU_IC_STATUS_SHIFT)); + regmap_write_bits(scu_ic->scu, scu_ic->reg, mask, + BIT(bit + ASPEED_SCU_IC_STATUS_SHIFT)); } chained_irq_exit(chip, desc); |