diff options
| author | Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com> | 2026-03-17 18:20:30 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2026-03-17 18:38:25 +0300 |
| commit | 88cf8a9ad32f85012eaf4bd1fe70ab39635ce89c (patch) | |
| tree | 48c58a9e3dbda7c1de3653a6233070a99b10221a | |
| parent | 678f946b40586a276421b2b4b6201665d6709119 (diff) | |
| download | linux-88cf8a9ad32f85012eaf4bd1fe70ab39635ce89c.tar.xz | |
mux: mmio: Zero the allocated memory
Zero the allocated memory in probe() for fields and hardware states
because:
1. The "hardware_states" array is not initialized in the probe, thus
starting the device with uninitialized memory. This not a bug,
because pointed memory will be assigned in suspend callback, however
it is a discouraged coding practice.
The "fields" array is initialized shortly further in the probe().
2. Linux kernel convention for safer code encourages using zeroed
allocations, as expressed in memory-allocation.rst document.
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Link: https://patch.msgid.link/20260317152029.274829-2-krzysztof.kozlowski@oss.qualcomm.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/mux/mmio.c | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/drivers/mux/mmio.c b/drivers/mux/mmio.c index 0611ef28bb69..b61e590f2ac9 100644 --- a/drivers/mux/mmio.c +++ b/drivers/mux/mmio.c @@ -100,12 +100,14 @@ static int mux_mmio_probe(struct platform_device *pdev) mux_mmio = mux_chip_priv(mux_chip); - mux_mmio->fields = devm_kmalloc(dev, num_fields * sizeof(*mux_mmio->fields), GFP_KERNEL); + mux_mmio->fields = devm_kcalloc(dev, num_fields, sizeof(*mux_mmio->fields), + GFP_KERNEL); if (!mux_mmio->fields) return -ENOMEM; - mux_mmio->hardware_states = devm_kmalloc(dev, num_fields * - sizeof(*mux_mmio->hardware_states), GFP_KERNEL); + mux_mmio->hardware_states = devm_kcalloc(dev, num_fields, + sizeof(*mux_mmio->hardware_states), + GFP_KERNEL); if (!mux_mmio->hardware_states) return -ENOMEM; |