diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2021-03-18 16:10:21 +0300 |
|---|---|---|
| committer | Steve French <stfrench@microsoft.com> | 2021-05-11 03:15:20 +0300 |
| commit | 86df49e105afa6a205abb7d90809c3c76136eaa9 (patch) | |
| tree | b5f188de558a5af3d8b8655c6b458edc258c9dd3 | |
| parent | e3f70873289ae84d42fe9cd3f01f99ae7a2b1f09 (diff) | |
| download | linux-86df49e105afa6a205abb7d90809c3c76136eaa9.tar.xz | |
cifsd: fix a precedence bug in parse_dacl()
The shift has higher precedence than mask so this doesn't work as
intended.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
| -rw-r--r-- | fs/cifsd/smbacl.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/cifsd/smbacl.c b/fs/cifsd/smbacl.c index 8d8360ca4751..294c5a8fe9af 100644 --- a/fs/cifsd/smbacl.c +++ b/fs/cifsd/smbacl.c @@ -520,7 +520,7 @@ static void parse_dacl(struct smb_acl *pdacl, char *end_of_acl, fattr->cf_gid; acl_state.groups->aces[acl_state.groups->n++].perms.allow = (mode & 0070) >> 3; - default_acl_state.group.allow = mode & 0070 >> 3; + default_acl_state.group.allow = (mode & 0070) >> 3; default_acl_state.groups->aces[default_acl_state.groups->n].gid = fattr->cf_gid; default_acl_state.groups->aces[default_acl_state.groups->n++].perms.allow = |