diff options
| author | Johan Hovold <johan@kernel.org> | 2017-11-11 18:38:44 +0300 |
|---|---|---|
| committer | Lee Jones <lee.jones@linaro.org> | 2017-11-29 19:29:36 +0300 |
| commit | 85e9b13cbb130a3209f21bd7933933399c389ffe (patch) | |
| tree | 697601b0a1b1d5da36e8d7f9a57f30e3ced70830 | |
| parent | 0a423772de2f3d7b00899987884f62f63ae00dcb (diff) | |
| download | linux-85e9b13cbb130a3209f21bd7933933399c389ffe.tar.xz | |
mfd: twl6040: Fix child-node lookup
Fix child-node lookup during probe, which ended up searching the whole
device tree depth-first starting at the parent rather than just matching
on its children.
To make things worse, the parent node was prematurely freed, while the
child node was leaked.
Note that the CONFIG_OF compile guard can be removed as
of_get_child_by_name() provides a !CONFIG_OF implementation which always
fails.
Cc: stable <stable@vger.kernel.org> # 3.5
Fixes: 37e13cecaa14 ("mfd: Add support for Device Tree to twl6040")
Fixes: ca2cad6ae38e ("mfd: Fix twl6040 build failure")
Signed-off-by: Johan Hovold <johan@kernel.org>
Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
| -rw-r--r-- | drivers/mfd/twl6040.c | 12 |
1 files changed, 8 insertions, 4 deletions
diff --git a/drivers/mfd/twl6040.c b/drivers/mfd/twl6040.c index d66502d36ba0..dd19f17a1b63 100644 --- a/drivers/mfd/twl6040.c +++ b/drivers/mfd/twl6040.c @@ -97,12 +97,16 @@ static struct reg_sequence twl6040_patch[] = { }; -static bool twl6040_has_vibra(struct device_node *node) +static bool twl6040_has_vibra(struct device_node *parent) { -#ifdef CONFIG_OF - if (of_find_node_by_name(node, "vibra")) + struct device_node *node; + + node = of_get_child_by_name(parent, "vibra"); + if (node) { + of_node_put(node); return true; -#endif + } + return false; } |