diff options
| author | Peter Ujfalusi <peter.ujfalusi@linux.intel.com> | 2022-12-21 13:23:27 +0300 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2022-12-26 02:32:38 +0300 |
| commit | 8419fd90ee5c9038cb2776fad71fcc9b93f78e11 (patch) | |
| tree | 4bf5b7a57ea0b7ce51f95e7feb2d01e445e3c483 | |
| parent | 1cf79c3484250d67180525662a247f8fecab3cea (diff) | |
| download | linux-8419fd90ee5c9038cb2776fad71fcc9b93f78e11.tar.xz | |
ASoC: SOF: trace: Use sof_ipc_get_ops() in sof_fw_trace_init
For the sake of safety use the sof_ipc_get_ops() to fetch the fw_tracing
ops to avoid cases when either sdev->ipc or sdev->ipc->ops might be NULL.
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Rander Wang <rander.wang@intel.com>
Link: https://lore.kernel.org/r/20221221102328.9635-11-peter.ujfalusi@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
| -rw-r--r-- | sound/soc/sof/trace.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/sound/soc/sof/trace.c b/sound/soc/sof/trace.c index 6f662642d611..0e92269c4a00 100644 --- a/sound/soc/sof/trace.c +++ b/sound/soc/sof/trace.c @@ -6,14 +6,16 @@ int sof_fw_trace_init(struct snd_sof_dev *sdev) { - if (!sdev->ipc->ops->fw_tracing) { + const struct sof_ipc_fw_tracing_ops *fw_tracing = sof_ipc_get_ops(sdev, fw_tracing); + + if (!fw_tracing) { dev_info(sdev->dev, "Firmware tracing is not available\n"); sdev->fw_trace_is_supported = false; return 0; } - return sdev->ipc->ops->fw_tracing->init(sdev); + return fw_tracing->init(sdev); } void sof_fw_trace_free(struct snd_sof_dev *sdev) |