diff options
| author | Guenter Roeck <groeck@chromium.org> | 2017-02-05 10:54:57 +0300 |
|---|---|---|
| committer | Mark Yao <mark.yao@rock-chips.com> | 2017-02-05 11:29:39 +0300 |
| commit | 83c132ed46a7e9c8ac17be436ef3892850df8695 (patch) | |
| tree | 0375c6b3b7da75e8aeff43c506b911ab3629bc6f | |
| parent | 1a0f7ed3abe29cff8e652c69a8ad89aec2c40f00 (diff) | |
| download | linux-83c132ed46a7e9c8ac17be436ef3892850df8695.tar.xz | |
drm/rockchip: cdn-dp: Load firmware if no monitor connected
If no monitor is connected, suspend/resume cycles result in firmware
load errors because the driver attempts to load the firmware while
the system is in suspend state. This results in a kernel warning and
traceback.
Loading the firmware during boot fixes the problem. Note that we can not
just call schedule_work conditionally in cdn_dp_pd_event() if the insertion
status changed. The problem would still be seen if a monitor is connected
for the first time during suspend.
Signed-off-by: Guenter Roeck <groeck@chromium.org>
Signed-off-by: Sean Paul <seanpaul@chromium.org>
Signed-off-by: Chris Zhong <zyw@rock-chips.com>
| -rw-r--r-- | drivers/gpu/drm/rockchip/cdn-dp-core.c | 7 |
1 files changed, 1 insertions, 6 deletions
diff --git a/drivers/gpu/drm/rockchip/cdn-dp-core.c b/drivers/gpu/drm/rockchip/cdn-dp-core.c index 7db25081a8ef..b8d0dd7abc61 100644 --- a/drivers/gpu/drm/rockchip/cdn-dp-core.c +++ b/drivers/gpu/drm/rockchip/cdn-dp-core.c @@ -1021,7 +1021,6 @@ static int cdn_dp_bind(struct device *dev, struct device *master, void *data) struct cdn_dp_port *port; struct drm_device *drm_dev = data; int ret, i; - bool schedule_event = false; ret = cdn_dp_parse_dt(dp); if (ret < 0) @@ -1083,15 +1082,11 @@ static int cdn_dp_bind(struct device *dev, struct device *master, void *data) "register EXTCON_DISP_DP notifier err\n"); goto err_free_connector; } - - if (extcon_get_state(port->extcon, EXTCON_DISP_DP)) - schedule_event = true; } pm_runtime_enable(dev); - if (schedule_event) - schedule_work(&dp->event_work); + schedule_work(&dp->event_work); return 0; |