diff options
| author | Jakub Kicinski <kuba@kernel.org> | 2026-05-10 22:28:59 +0300 |
|---|---|---|
| committer | Paolo Abeni <pabeni@redhat.com> | 2026-05-12 17:14:59 +0300 |
| commit | 8054f85b83f42a37d482fc77ea7c9ff06a9407d9 (patch) | |
| tree | 641ca061e8366e96c1e3e7b6b74fd8e7b7ccb4da | |
| parent | 6e8ae9d805d4b9ecec49bb9e457d9bae0b21b540 (diff) | |
| download | linux-8054f85b83f42a37d482fc77ea7c9ff06a9407d9.tar.xz | |
net: shaper: set ret to -ENOMEM when genlmsg_new() fails in group_doit
genlmsg_new() alloc failure path in net_shaper_nl_group_doit() forgets
to set ret before jumping to error handling.
Fixes: 5d5d4700e75d ("net-shapers: implement NL group operation")
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Link: https://patch.msgid.link/20260510192904.3987113-6-kuba@kernel.org
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
| -rw-r--r-- | net/shaper/shaper.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/net/shaper/shaper.c b/net/shaper/shaper.c index c8960821cf23..12e5e0c18643 100644 --- a/net/shaper/shaper.c +++ b/net/shaper/shaper.c @@ -1276,8 +1276,10 @@ int net_shaper_nl_group_doit(struct sk_buff *skb, struct genl_info *info) * rollback on allocation failure. */ msg = genlmsg_new(net_shaper_handle_size(), GFP_KERNEL); - if (!msg) + if (!msg) { + ret = -ENOMEM; goto free_leaves; + } hierarchy = net_shaper_hierarchy_setup(binding); if (!hierarchy) { |