diff options
| author | Dinghao Liu <dinghao.liu@zju.edu.cn> | 2020-08-24 08:58:31 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2020-08-24 15:58:41 +0300 |
| commit | 7ef1fc57301f3cef7201497aa27e89ccb91737fe (patch) | |
| tree | ce44405b99eacb60edbffb7bf4c2cddac60a07fd | |
| parent | 100e3345c6e719d2291e1efd5de311cc24bb9c0b (diff) | |
| download | linux-7ef1fc57301f3cef7201497aa27e89ccb91737fe.tar.xz | |
net: systemport: Fix memleak in bcm_sysport_probe
When devm_kcalloc() fails, dev should be freed just
like what we've done in the subsequent error paths.
Fixes: 7b78be48a8eb6 ("net: systemport: Dynamically allocate number of TX rings")
Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/ethernet/broadcom/bcmsysport.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/drivers/net/ethernet/broadcom/bcmsysport.c b/drivers/net/ethernet/broadcom/bcmsysport.c index dfed9ade6950..0762d5d1a810 100644 --- a/drivers/net/ethernet/broadcom/bcmsysport.c +++ b/drivers/net/ethernet/broadcom/bcmsysport.c @@ -2491,8 +2491,10 @@ static int bcm_sysport_probe(struct platform_device *pdev) priv->tx_rings = devm_kcalloc(&pdev->dev, txq, sizeof(struct bcm_sysport_tx_ring), GFP_KERNEL); - if (!priv->tx_rings) - return -ENOMEM; + if (!priv->tx_rings) { + ret = -ENOMEM; + goto err_free_netdev; + } priv->is_lite = params->is_lite; priv->num_rx_desc_words = params->num_rx_desc_words; |