diff options
| author | Ethan Tidmore <ethantidmore06@gmail.com> | 2026-02-26 07:03:55 +0300 |
|---|---|---|
| committer | Namjae Jeon <linkinjeon@kernel.org> | 2026-02-26 12:26:12 +0300 |
| commit | 7c76484fbb222e82f1db34009eb441d08db0a158 (patch) | |
| tree | 7b6f149410d248d22170243daff0d1fe41a9a7e3 | |
| parent | ec8676c84f665257f4bf9349d4c12c05e09e31b3 (diff) | |
| download | linux-7c76484fbb222e82f1db34009eb441d08db0a158.tar.xz | |
ntfs: Remove impossible condition
The variable name_len is checked to see if it's larger than the macro
NTFS_MAX_NAME_LEN however this condition is impossible because name_len
is of type u8 and NTFS_MAX_NAME_LEN is hardcoded to be 255.
Detected by Smatch:
fs/ntfs/namei.c:1175 __ntfs_link() warn:
impossible condition '(name_len > 255) => (0-255 > 255)'
Signed-off-by: Ethan Tidmore <ethantidmore06@gmail.com>
Reviewed-by: Hyunchul Lee <hyc.lee@gmail.com>
Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>
| -rw-r--r-- | fs/ntfs/namei.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/fs/ntfs/namei.c b/fs/ntfs/namei.c index cecfaabfbfe7..2952b377dda2 100644 --- a/fs/ntfs/namei.c +++ b/fs/ntfs/namei.c @@ -1172,10 +1172,7 @@ static int __ntfs_link(struct ntfs_inode *ni, struct ntfs_inode *dir_ni, /* Create FILE_NAME attribute. */ fn_len = sizeof(struct file_name_attr) + name_len * sizeof(__le16); - if (name_len > NTFS_MAX_NAME_LEN) { - err = -EIO; - goto err_out; - } + fn = kzalloc(fn_len, GFP_NOFS); if (!fn) { err = -ENOMEM; |