diff options
| author | Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com> | 2025-03-23 15:49:06 +0300 |
|---|---|---|
| committer | Matthew Brost <matthew.brost@intel.com> | 2025-04-22 19:25:44 +0300 |
| commit | 7a0322122cfdd9a6f10fc7701023d75c98eb3d22 (patch) | |
| tree | 12f19857e1f551478a4779e8362849dbb3daa8f4 | |
| parent | 104080e33937aad54b4fbbe847bba750847abfdb (diff) | |
| download | linux-7a0322122cfdd9a6f10fc7701023d75c98eb3d22.tar.xz | |
drm/xe/svm: fix dereferencing error pointer in drm_gpusvm_range_alloc()
xe_svm_range_alloc() returns ERR_PTR(-ENOMEM) on failure and there is a
dereference of "range" after that:
--> range->gpusvm = gpusvm;
In xe_svm_range_alloc(), when memory allocation fails return NULL
instead to handle this situation.
Fixes: 99624bdff867 ("drm/gpusvm: Add support for GPU Shared Virtual Memory")
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/all/adaef4dd-5866-48ca-bc22-4a1ddef20381@stanley.mountain/
Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Reviewed-by: Matthew Brost <matthew.brost@intel.com>
Signed-off-by: Matthew Brost <matthew.brost@intel.com>
Link: https://lore.kernel.org/r/20250323124907.3946370-1-harshit.m.mogalapalli@oracle.com
| -rw-r--r-- | drivers/gpu/drm/xe/xe_svm.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpu/drm/xe/xe_svm.c b/drivers/gpu/drm/xe/xe_svm.c index c7424c824a14..d927f50f2a68 100644 --- a/drivers/gpu/drm/xe/xe_svm.c +++ b/drivers/gpu/drm/xe/xe_svm.c @@ -80,7 +80,7 @@ xe_svm_range_alloc(struct drm_gpusvm *gpusvm) range = kzalloc(sizeof(*range), GFP_KERNEL); if (!range) - return ERR_PTR(-ENOMEM); + return NULL; INIT_LIST_HEAD(&range->garbage_collector_link); xe_vm_get(gpusvm_to_vm(gpusvm)); |