summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDominik Karol PiÄ…tkowski <dominik.karol.piatkowski@protonmail.com>2026-01-16 20:48:59 +0300
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2026-01-27 18:04:08 +0300
commit78047416f80007b25062bd4791d98e24c0aaa687 (patch)
tree449e9246832849265248997990f138f6db174ffb
parent64900aa878fc6a5f2a017374f869890749c9382e (diff)
downloadlinux-78047416f80007b25062bd4791d98e24c0aaa687.tar.xz
gpib: ni_usb: Fix the *allocate_private retval check
Change if (retval < 0) return retval; into if (retval) return retval; as it is more fitting in this case. Signed-off-by: Dominik Karol PiÄ…tkowski <dominik.karol.piatkowski@protonmail.com> Link: https://patch.msgid.link/20260116174647.317256-22-dominik.karol.piatkowski@protonmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/gpib/ni_usb/ni_usb_gpib.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpib/ni_usb/ni_usb_gpib.c b/drivers/gpib/ni_usb/ni_usb_gpib.c
index b062360fff00..c6f1a70d44f5 100644
--- a/drivers/gpib/ni_usb/ni_usb_gpib.c
+++ b/drivers/gpib/ni_usb/ni_usb_gpib.c
@@ -2234,7 +2234,7 @@ static int ni_usb_attach(struct gpib_board *board, const struct gpib_board_confi
mutex_lock(&ni_usb_hotplug_lock);
retval = ni_usb_allocate_private(board);
- if (retval < 0) {
+ if (retval) {
mutex_unlock(&ni_usb_hotplug_lock);
return retval;
}