diff options
| author | Anas Iqbal <mohd.abd.6602@gmail.com> | 2026-04-01 00:07:39 +0300 |
|---|---|---|
| committer | Jens Axboe <axboe@kernel.dk> | 2026-04-01 19:21:13 +0300 |
| commit | 77d8c8d0f1b76a005267ee9714ed98964c87ecc5 (patch) | |
| tree | 4db4d4214c289ee9602eef9f7cf81e9121cfdb93 | |
| parent | a9d008489f0c5304ca7f705348324e47824a7454 (diff) | |
| download | linux-77d8c8d0f1b76a005267ee9714ed98964c87ecc5.tar.xz | |
io_uring: cast id to u64 before shifting in io_allocate_rbuf_ring()
Smatch warns:
io_uring/zcrx.c:393 io_allocate_rbuf_ring() warn: should 'id << 16' be a 64 bit type?
The expression 'id << IORING_OFF_PBUF_SHIFT' is evaluated using 32-bit
arithmetic because id is a u32. This may overflow before being promoted
to the 64-bit mmap_offset.
Cast id to u64 before shifting to ensure the shift is performed in
64-bit arithmetic.
Signed-off-by: Anas Iqbal <mohd.abd.6602@gmail.com>
Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
Link: https://patch.msgid.link/52400e1b343691416bef3ed3ae287fb1a88d407f.1774780198.git.asml.silence@gmail.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
| -rw-r--r-- | io_uring/zcrx.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/io_uring/zcrx.c b/io_uring/zcrx.c index 1ce867c68446..b8f15439d5df 100644 --- a/io_uring/zcrx.c +++ b/io_uring/zcrx.c @@ -384,7 +384,7 @@ static int io_allocate_rbuf_ring(struct io_ring_ctx *ctx, return -EINVAL; mmap_offset = IORING_MAP_OFF_ZCRX_REGION; - mmap_offset += id << IORING_OFF_PBUF_SHIFT; + mmap_offset += (u64)id << IORING_OFF_PBUF_SHIFT; ret = io_create_region(ctx, &ifq->rq_region, rd, mmap_offset); if (ret < 0) |