summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorYang Li <yang.lee@linux.alibaba.com>2023-02-15 21:31:37 +0300
committerKalle Valo <quic_kvalo@quicinc.com>2023-02-17 19:09:12 +0300
commit731e1b36656a30ffa9c77de673695cdc733d6c92 (patch)
tree8e906dd78d348db8cdb01d70edcd3cc8efe09512
parent480c9df5778774117546f6389be1a8dc8cc935db (diff)
downloadlinux-731e1b36656a30ffa9c77de673695cdc733d6c92.tar.xz
wifi: ath12k: dp_mon: Fix unsigned comparison with less than zero
The return value from the call to idr_alloc() is int. However, the return value is being assigned to an unsigned int variable 'buf_id', so making 'buf_id' an int. Eliminate the following warning: ./drivers/net/wireless/ath/ath12k/dp_mon.c:1300:15-21: WARNING: Unsigned expression compared with zero: buf_id < 0 Reported-by: Abaci Robot <abaci@linux.alibaba.com> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4060 Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com> Link: https://lore.kernel.org/r/20230215011453.73466-1-yang.lee@linux.alibaba.com
-rw-r--r--drivers/net/wireless/ath/ath12k/dp_mon.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/net/wireless/ath/ath12k/dp_mon.c b/drivers/net/wireless/ath/ath12k/dp_mon.c
index 4f93e4c95fed..85f8f802340d 100644
--- a/drivers/net/wireless/ath/ath12k/dp_mon.c
+++ b/drivers/net/wireless/ath/ath12k/dp_mon.c
@@ -1268,7 +1268,8 @@ int ath12k_dp_mon_buf_replenish(struct ath12k_base *ab,
struct sk_buff *skb;
struct hal_srng *srng;
dma_addr_t paddr;
- u32 cookie, buf_id;
+ u32 cookie;
+ int buf_id;
srng = &ab->hal.srng_list[buf_ring->refill_buf_ring.ring_id];
spin_lock_bh(&srng->lock);