diff options
| author | Michael Rubin <matchstick@neverthere.org> | 2025-04-09 01:36:58 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2025-04-15 17:37:13 +0300 |
| commit | 72ba314072a66774d5a90141ec99128c6bab033a (patch) | |
| tree | 8a87af1309792daa42e84c5c87ad6bae1c7b0b62 | |
| parent | b8a16f6cc987bc86fecbd70d9c6002b9ec109712 (diff) | |
| download | linux-72ba314072a66774d5a90141ec99128c6bab033a.tar.xz | |
staging: gpib: Removing typedef gpib_board_config
Removing gpib_interface_t to adhere to Linux code style.
Reported by checkpatch.pl
In general, a pointer, or a struct that has elements that can reasonably be
directly accessed should never be a typedef.
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250408223659.187109-19-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/staging/gpib/include/gpib_types.h | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/staging/gpib/include/gpib_types.h b/drivers/staging/gpib/include/gpib_types.h index 9af5fdd1497f..f4cb346b8a02 100644 --- a/drivers/staging/gpib/include/gpib_types.h +++ b/drivers/staging/gpib/include/gpib_types.h @@ -24,7 +24,6 @@ typedef struct gpib_interface_struct gpib_interface_t; struct gpib_board; -typedef struct gpib_board_config gpib_board_config_t; /* config parameters that are only used by driver attach functions */ struct gpib_board_config { @@ -56,7 +55,7 @@ struct gpib_interface_struct { /* name of board */ char *name; /* attach() initializes board and allocates resources */ - int (*attach)(struct gpib_board *board, const gpib_board_config_t *config); + int (*attach)(struct gpib_board *board, const struct gpib_board_config *config); /* detach() shuts down board and frees resources */ void (*detach)(struct gpib_board *board); /* read() should read at most 'length' bytes from the bus into @@ -292,7 +291,7 @@ struct gpib_board { struct gpib_pseudo_irq pseudo_irq; /* error dong autopoll */ atomic_t stuck_srq; - gpib_board_config_t config; + struct gpib_board_config config; /* Flag that indicates whether board is system controller of the bus */ unsigned master : 1; /* individual status bit */ |