diff options
| author | NeilBrown <neilb@suse.de> | 2024-12-06 05:55:53 +0300 |
|---|---|---|
| committer | Chuck Lever <chuck.lever@oracle.com> | 2025-01-06 17:37:34 +0300 |
| commit | 6e1d75f778d644d02147d8e61ca2cef033ce045d (patch) | |
| tree | 65cf02919125515bda2fa01da0aafab370d0ad29 | |
| parent | 935fee5d5ba8073b223a9cc9906a62950f0e13ed (diff) | |
| download | linux-6e1d75f778d644d02147d8e61ca2cef033ce045d.tar.xz | |
sunrpc/svc: use store_release_wake_up()
svc_thread_init_status() contains an open-coded
store_release_wake_up(). It is cleaner to use that function directly
rather than needing to remember the barrier.
Signed-off-by: NeilBrown <neilb@suse.de>
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
| -rw-r--r-- | include/linux/sunrpc/svc.h | 7 |
1 files changed, 1 insertions, 6 deletions
diff --git a/include/linux/sunrpc/svc.h b/include/linux/sunrpc/svc.h index e68fecf6eab5..e4f09f58d58c 100644 --- a/include/linux/sunrpc/svc.h +++ b/include/linux/sunrpc/svc.h @@ -327,12 +327,7 @@ static inline bool svc_thread_should_stop(struct svc_rqst *rqstp) */ static inline void svc_thread_init_status(struct svc_rqst *rqstp, int err) { - rqstp->rq_err = err; - /* memory barrier ensures assignment to error above is visible before - * waitqueue_active() test below completes. - */ - smp_mb(); - wake_up_var(&rqstp->rq_err); + store_release_wake_up(&rqstp->rq_err, err); if (err) kthread_exit(1); } |