diff options
| author | Markus Stockhausen <markus.stockhausen@gmx.de> | 2026-06-03 20:59:20 +0300 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2026-06-06 04:38:55 +0300 |
| commit | 67885c0e3919be0f39d8f69e4eb446c9df8fa5fc (patch) | |
| tree | 9ea5d253d10e5a4dfb101ba14c83483c1782bcdd | |
| parent | 829ee0f8bc3920092b06d32d9e05328395ed5b77 (diff) | |
| download | linux-67885c0e3919be0f39d8f69e4eb446c9df8fa5fc.tar.xz | |
net: mdio: realtek-rtl9300: harden otto_emdio_probe_one()
The bus probing of the MDIO driver uses a two stage approach.
1. The device tree "ethernet-ports" node is scanned to build a mapping
between ports and PHYs.
2. The children of the device tree "controller" are scanned to create
the individual MDIO buses.
The first step already checks the consistency of the PHY and bus nodes
that are linked via the ports. But it might miss a dangling bus child
node that is not linked. Step two simply iterates over all bus child
nodes and might read malformed data from nodes not checked in step one.
Harden this and return a meaningful error message.
Signed-off-by: Markus Stockhausen <markus.stockhausen@gmx.de>
Link: https://patch.msgid.link/20260603175924.123019-4-markus.stockhausen@gmx.de
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
| -rw-r--r-- | drivers/net/mdio/mdio-realtek-rtl9300.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/drivers/net/mdio/mdio-realtek-rtl9300.c b/drivers/net/mdio/mdio-realtek-rtl9300.c index ba4151fbae0d..aa45b0e92216 100644 --- a/drivers/net/mdio/mdio-realtek-rtl9300.c +++ b/drivers/net/mdio/mdio-realtek-rtl9300.c @@ -380,7 +380,11 @@ static int otto_emdio_probe_one(struct device *dev, struct otto_emdio_priv *priv err = fwnode_property_read_u32(node, "reg", &mdio_bus); if (err) - return err; + return dev_err_probe(dev, err, "undefined smi bus number\n"); + + if (mdio_bus >= priv->info->num_buses) + return dev_err_probe(dev, -EINVAL, + "illegal (dangling) smi bus number %d\n", mdio_bus); /* The MDIO accesses from the kernel work with the PHY polling unit in * the switch. We need to tell the PPU to operate either in GPHY (i.e. |