diff options
| author | Rob Herring (Arm) <robh@kernel.org> | 2024-11-06 20:08:07 +0300 |
|---|---|---|
| committer | Rob Herring (Arm) <robh@kernel.org> | 2024-11-08 22:15:54 +0300 |
| commit | 67759cfb043ae753fb56c3130375b66276633528 (patch) | |
| tree | 591fd2dd161859d5ae22f737dbf6c8249065633f | |
| parent | 01d0467488c72e6d30cbc3261a3020080ba02378 (diff) | |
| download | linux-67759cfb043ae753fb56c3130375b66276633528.tar.xz | |
of/fdt: Don't use default address cell sizes for address translation
FDT systems should never be relying on default cell sizes. It's been a
warning in dtc since 2007. The behavior here doesn't even match the
unflattened code which will walk the parent nodes looking for the cell
size properties (also deprecated). Furthermore, the FDT address
translation code is only used in one spot by SH and for earlycon which
was added 2014 and certainly isn't used on Powerpc systems.
Returning -1 values will result in an error message.
Link: https://lore.kernel.org/r/20241106170808.3827790-1-robh@kernel.org
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
| -rw-r--r-- | drivers/of/fdt_address.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/of/fdt_address.c b/drivers/of/fdt_address.c index 1dc15ab78b10..9804d7f06705 100644 --- a/drivers/of/fdt_address.c +++ b/drivers/of/fdt_address.c @@ -55,7 +55,7 @@ static void __init fdt_bus_default_count_cells(const void *blob, int parentoffse if (prop) *addrc = be32_to_cpup(prop); else - *addrc = dt_root_addr_cells; + *addrc = -1; } if (sizec) { @@ -63,7 +63,7 @@ static void __init fdt_bus_default_count_cells(const void *blob, int parentoffse if (prop) *sizec = be32_to_cpup(prop); else - *sizec = dt_root_size_cells; + *sizec = -1; } } |