diff options
| author | Murad Masimov <m.masimov@mt-integration.ru> | 2025-03-11 17:22:05 +0300 |
|---|---|---|
| committer | Steve French <stfrench@microsoft.com> | 2025-03-13 16:41:28 +0300 |
| commit | 64f690ee22c99e16084e0e45181b2a1eed2fa149 (patch) | |
| tree | f136099639c07d55dd66593f20659db12f94bfca | |
| parent | 5b29891f91dfb8758baf1e2217bef4b16b2b165b (diff) | |
| download | linux-64f690ee22c99e16084e0e45181b2a1eed2fa149.tar.xz | |
cifs: Fix integer overflow while processing actimeo mount option
User-provided mount parameter actimeo of type u32 is intended to have
an upper limit, but before it is validated, the value is converted from
seconds to jiffies which can lead to an integer overflow.
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Fixes: 6d20e8406f09 ("cifs: add attribute cache timeout (actimeo) tunable")
Signed-off-by: Murad Masimov <m.masimov@mt-integration.ru>
Signed-off-by: Steve French <stfrench@microsoft.com>
| -rw-r--r-- | fs/smb/client/fs_context.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/smb/client/fs_context.c b/fs/smb/client/fs_context.c index c983021c406b..85b062e7f48d 100644 --- a/fs/smb/client/fs_context.c +++ b/fs/smb/client/fs_context.c @@ -1358,7 +1358,7 @@ static int smb3_fs_context_parse_param(struct fs_context *fc, ctx->acdirmax = HZ * result.uint_32; break; case Opt_actimeo: - if (HZ * result.uint_32 > CIFS_MAX_ACTIMEO) { + if (result.uint_32 > CIFS_MAX_ACTIMEO / HZ) { cifs_errorf(fc, "timeout too large\n"); goto cifs_parse_mount_err; } |