diff options
| author | Veaceslav Falico <vfalico@redhat.com> | 2013-08-02 21:07:38 +0400 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2013-08-03 02:44:23 +0400 |
| commit | 63134803a6369dcf7dddf7f0d5e37b9566b308d2 (patch) | |
| tree | 91989560d7550d8664835abbe977beabe01e137e | |
| parent | 8a849bb7f0ac513c2b7202620f611d94301c4a93 (diff) | |
| download | linux-63134803a6369dcf7dddf7f0d5e37b9566b308d2.tar.xz | |
neighbour: populate neigh_parms on alloc before calling ndo_neigh_setup
dev->ndo_neigh_setup() might need some of the values of neigh_parms, so
populate them before calling it.
Signed-off-by: Veaceslav Falico <vfalico@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | net/core/neighbour.c | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/net/core/neighbour.c b/net/core/neighbour.c index b7de821f98df..576d46f4a69e 100644 --- a/net/core/neighbour.c +++ b/net/core/neighbour.c @@ -1441,16 +1441,18 @@ struct neigh_parms *neigh_parms_alloc(struct net_device *dev, atomic_set(&p->refcnt, 1); p->reachable_time = neigh_rand_reach_time(p->base_reachable_time); + dev_hold(dev); + p->dev = dev; + write_pnet(&p->net, hold_net(net)); + p->sysctl_table = NULL; if (ops->ndo_neigh_setup && ops->ndo_neigh_setup(dev, p)) { + release_net(net); + dev_put(dev); kfree(p); return NULL; } - dev_hold(dev); - p->dev = dev; - write_pnet(&p->net, hold_net(net)); - p->sysctl_table = NULL; write_lock_bh(&tbl->lock); p->next = tbl->parms.next; tbl->parms.next = p; |