summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBen Hutchings <ben@decadent.org.uk>2017-11-06 05:50:25 +0300
committerBen Hutchings <ben@decadent.org.uk>2017-11-11 16:34:49 +0300
commit5df98fd0a5d24fd082889eb1448cf68199f77cd9 (patch)
treeb4c47c75d3b3fcab3dd93292029a9b1306e9abb0
parenta481b9a8b1e54d0ab7acc3ec6eb881bb8a18cdff (diff)
downloadlinux-5df98fd0a5d24fd082889eb1448cf68199f77cd9.tar.xz
mct_u232: Fix use of uninitialized pointer in mct_u323_startup()
My backport of commit 4e9a0b05257f "USB: mct_u232: add sanity checking in probe" incorrectly added a dev_err() call using port->dev before 'port' was initialised. Use the 'serial' parameter to look up the device instead. Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
-rw-r--r--drivers/usb/serial/mct_u232.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/usb/serial/mct_u232.c b/drivers/usb/serial/mct_u232.c
index ed8694b1a0f4..8901b8d1bbe0 100644
--- a/drivers/usb/serial/mct_u232.c
+++ b/drivers/usb/serial/mct_u232.c
@@ -449,7 +449,7 @@ static int mct_u232_startup(struct usb_serial *serial)
/* check first to simplify error handling */
if (!serial->port[1] || !serial->port[1]->interrupt_in_urb) {
- dev_err(&port->dev, "expected endpoint missing\n");
+ dev_err(&serial->dev->dev, "expected endpoint missing\n");
return -ENODEV;
}