summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMichał Mirosław <mirq-linux@rere.qmqm.pl>2021-07-26 11:30:56 +0300
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2021-09-03 10:58:01 +0300
commit5da47bf1612fbf2ce350b38fdf13ce49e8805ecc (patch)
tree65340923220a7f4466334598aee8d7649c764874
parent6a600523e323e58dadc6322e21270d4ba8757685 (diff)
downloadlinux-5da47bf1612fbf2ce350b38fdf13ce49e8805ecc.tar.xz
opp: remove WARN when no valid OPPs remain
[ Upstream commit 335ffab3ef864539e814b9a2903b0ae420c1c067 ] This WARN can be triggered per-core and the stack trace is not useful. Replace it with plain dev_err(). Fix a comment while at it. Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
-rw-r--r--drivers/opp/of.c5
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/opp/of.c b/drivers/opp/of.c
index d64a13d7881b..a53123356697 100644
--- a/drivers/opp/of.c
+++ b/drivers/opp/of.c
@@ -423,8 +423,9 @@ static int _of_add_opp_table_v2(struct device *dev, struct device_node *opp_np)
}
}
- /* There should be one of more OPP defined */
- if (WARN_ON(!count)) {
+ /* There should be one or more OPPs defined */
+ if (!count) {
+ dev_err(dev, "%s: no supported OPPs", __func__);
ret = -ENOENT;
goto put_opp_table;
}