summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>2025-02-07 18:17:14 +0300
committerBartosz Golaszewski <bartosz.golaszewski@linaro.org>2025-02-11 11:41:09 +0300
commit5892cfc7db9814a71c991da7024fa03384e48924 (patch)
tree1420ef20bd1b668dc28a82db9958eb6a020d46e5
parent9bd2dbe4066b3821b68f3e18ba91a3a1cd6354df (diff)
downloadlinux-5892cfc7db9814a71c991da7024fa03384e48924.tar.xz
gpio: 74x164: Utilise temporary variable for struct device
We have a temporary variable to keep a pointer to struct device. Utilise it where it makes sense. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Link: https://lore.kernel.org/r/20250207151825.2122419-8-andriy.shevchenko@linux.intel.com [Bartosz: finish the job by converting three more instances] Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
-rw-r--r--drivers/gpio/gpio-74x164.c13
1 files changed, 6 insertions, 7 deletions
diff --git a/drivers/gpio/gpio-74x164.c b/drivers/gpio/gpio-74x164.c
index bbeef03e3797..640ac24b72a2 100644
--- a/drivers/gpio/gpio-74x164.c
+++ b/drivers/gpio/gpio-74x164.c
@@ -124,7 +124,7 @@ static int gen_74x164_probe(struct spi_device *spi)
if (ret < 0)
return ret;
- ret = device_property_read_u32(&spi->dev, "registers-number", &nregs);
+ ret = device_property_read_u32(dev, "registers-number", &nregs);
if (ret)
return dev_err_probe(dev, ret, "Missing 'registers-number' property.\n");
@@ -134,8 +134,7 @@ static int gen_74x164_probe(struct spi_device *spi)
chip->registers = nregs;
- chip->gpiod_oe = devm_gpiod_get_optional(&spi->dev, "enable",
- GPIOD_OUT_LOW);
+ chip->gpiod_oe = devm_gpiod_get_optional(dev, "enable", GPIOD_OUT_LOW);
if (IS_ERR(chip->gpiod_oe))
return PTR_ERR(chip->gpiod_oe);
@@ -147,22 +146,22 @@ static int gen_74x164_probe(struct spi_device *spi)
chip->gpio_chip.base = -1;
chip->gpio_chip.ngpio = GEN_74X164_NUMBER_GPIOS * chip->registers;
chip->gpio_chip.can_sleep = true;
- chip->gpio_chip.parent = &spi->dev;
+ chip->gpio_chip.parent = dev;
chip->gpio_chip.owner = THIS_MODULE;
- ret = devm_mutex_init(&spi->dev, &chip->lock);
+ ret = devm_mutex_init(dev, &chip->lock);
if (ret)
return ret;
ret = __gen_74x164_write_config(chip);
if (ret)
- return dev_err_probe(&spi->dev, ret, "Config write failed\n");
+ return dev_err_probe(dev, ret, "Config write failed\n");
ret = gen_74x164_activate(dev, chip);
if (ret)
return ret;
- return devm_gpiochip_add_data(&spi->dev, &chip->gpio_chip, chip);
+ return devm_gpiochip_add_data(dev, &chip->gpio_chip, chip);
}
static const struct spi_device_id gen_74x164_spi_ids[] = {