summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTong Tiangen <tongtiangen@huawei.com>2021-06-01 13:01:55 +0300
committerHerbert Xu <herbert@gondor.apana.org.au>2021-06-11 10:02:14 +0300
commit57c126661f50b884d3812e7db6e00f2e778eccfb (patch)
tree95245ad3b04b8c548d226ec4e9473e4a7cfdb9f1
parent760fe22cf5e9f5d0212aa4c9aef555625c167627 (diff)
downloadlinux-57c126661f50b884d3812e7db6e00f2e778eccfb.tar.xz
crypto: nitrox - fix unchecked variable in nitrox_register_interrupts
Function nitrox_register_interrupts leaves variable 'nr_vecs' unchecked, which would be use as kcalloc parameter later. Fixes: 5155e118dda9 ("crypto: cavium/nitrox - use pci_alloc_irq_vectors() while enabling MSI-X.") Signed-off-by: Tong Tiangen <tongtiangen@huawei.com> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
-rw-r--r--drivers/crypto/cavium/nitrox/nitrox_isr.c4
1 files changed, 4 insertions, 0 deletions
diff --git a/drivers/crypto/cavium/nitrox/nitrox_isr.c b/drivers/crypto/cavium/nitrox/nitrox_isr.c
index c288c4b51783..f19e520da6d0 100644
--- a/drivers/crypto/cavium/nitrox/nitrox_isr.c
+++ b/drivers/crypto/cavium/nitrox/nitrox_isr.c
@@ -307,6 +307,10 @@ int nitrox_register_interrupts(struct nitrox_device *ndev)
* Entry 192: NPS_CORE_INT_ACTIVE
*/
nr_vecs = pci_msix_vec_count(pdev);
+ if (nr_vecs < 0) {
+ dev_err(DEV(ndev), "Error in getting vec count %d\n", nr_vecs);
+ return nr_vecs;
+ }
/* Enable MSI-X */
ret = pci_alloc_irq_vectors(pdev, nr_vecs, nr_vecs, PCI_IRQ_MSIX);