diff options
| author | Yu Kuai <yukuai3@huawei.com> | 2024-10-31 06:31:09 +0300 |
|---|---|---|
| committer | Song Liu <song@kernel.org> | 2024-11-06 03:08:38 +0300 |
| commit | 50e8274855e7ab5499ff8296e09802874a3f03b1 (patch) | |
| tree | 9b3edf52bae34cfb81e9615ab4321b8c18c5a4d5 | |
| parent | 4abfce19c7fb090c93e6677e26b2c709ca6f6fd8 (diff) | |
| download | linux-50e8274855e7ab5499ff8296e09802874a3f03b1.tar.xz | |
md: don't wait faulty rdev in md_wait_for_blocked_rdev()
md_wait_for_blocked_rdev() is called for write IO while rdev is
blocked, howerver, rdev can be faulty after choosing this rdev to write,
and faulty rdev should never be accessed anymore, hence there is no point
to wait for faulty rdev to be unblocked.
Signed-off-by: Yu Kuai <yukuai3@huawei.com>
Tested-by: Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com>
Link: https://lore.kernel.org/r/20241031033114.3845582-3-yukuai1@huaweicloud.com
Signed-off-by: Song Liu <song@kernel.org>
| -rw-r--r-- | drivers/md/md.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/md/md.c b/drivers/md/md.c index 179ee4afe937..b2a0e0a84309 100644 --- a/drivers/md/md.c +++ b/drivers/md/md.c @@ -9762,9 +9762,7 @@ EXPORT_SYMBOL(md_reap_sync_thread); void md_wait_for_blocked_rdev(struct md_rdev *rdev, struct mddev *mddev) { sysfs_notify_dirent_safe(rdev->sysfs_state); - wait_event_timeout(rdev->blocked_wait, - !test_bit(Blocked, &rdev->flags) && - !test_bit(BlockedBadBlocks, &rdev->flags), + wait_event_timeout(rdev->blocked_wait, !rdev_blocked(rdev), msecs_to_jiffies(5000)); rdev_dec_pending(rdev, mddev); } |