diff options
| author | David Howells <dhowells@redhat.com> | 2026-05-12 15:33:55 +0300 |
|---|---|---|
| committer | Christian Brauner <brauner@kernel.org> | 2026-05-12 15:42:32 +0300 |
| commit | 5046a34f0643441f05b0253ea64e1a3af87efe14 (patch) | |
| tree | 0a0f62e7bc05fe40b30bfef91b2d6e0a4959f735 | |
| parent | 3e5dd91b87a8b1450217b56a336bee315f40da7d (diff) | |
| download | linux-5046a34f0643441f05b0253ea64e1a3af87efe14.tar.xz | |
netfs: Fix leak of request in netfs_write_begin() error handling
Fix netfs_write_begin() to not leak our ref on the request in the event
that we get an error from netfs_wait_for_read().
Fixes: 4090b31422a6 ("netfs: Add a function to consolidate beginning a read")
Closes: https://sashiko.dev/#/patchset/20260414082004.3756080-1-dhowells%40redhat.com
Signed-off-by: David Howells <dhowells@redhat.com>
Link: https://patch.msgid.link/20260512123404.719402-19-dhowells@redhat.com
cc: Paulo Alcantara <pc@manguebit.org>
cc: Matthew Wilcox <willy@infradead.org>
cc: netfs@lists.linux.dev
cc: linux-fsdevel@vger.kernel.org
Signed-off-by: Christian Brauner <brauner@kernel.org>
| -rw-r--r-- | fs/netfs/buffered_read.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/netfs/buffered_read.c b/fs/netfs/buffered_read.c index e7ad511e494c..004d426c02b4 100644 --- a/fs/netfs/buffered_read.c +++ b/fs/netfs/buffered_read.c @@ -687,9 +687,9 @@ retry: netfs_read_to_pagecache(rreq, NULL); ret = netfs_wait_for_read(rreq); + netfs_put_request(rreq, netfs_rreq_trace_put_return); if (ret < 0) goto error; - netfs_put_request(rreq, netfs_rreq_trace_put_return); have_folio: ret = folio_wait_private_2_killable(folio); |