diff options
| author | NeilBrown <neil@brown.name> | 2026-02-25 01:16:48 +0300 |
|---|---|---|
| committer | Christian Brauner <brauner@kernel.org> | 2026-03-06 12:24:11 +0300 |
| commit | 4eb94abd6bc8989d7478b9fdbff4dab5abc11ef7 (patch) | |
| tree | 3c8cfe2ccf7aca66ba4c9214f7f89ea9a41ea25b | |
| parent | 9ab68389843a434d7d49e2a986ebf6d01d81ae42 (diff) | |
| download | linux-4eb94abd6bc8989d7478b9fdbff4dab5abc11ef7.tar.xz | |
VFS: move the start_dirop() kerndoc comment to before start_dirop()
This kerneldoc comment was always meant for start_dirop(), not for
__start_dirop() which is a static function and doesn't need
documentation.
It was in the wrong place and was then incorrectly renamed (instead of
moved) and useless "documentation" was added for "@state" was provided.
This patch reverts the name, removes the mention of @state, and moves
the comment to where it belongs.
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: NeilBrown <neil@brown.name>
Link: https://patch.msgid.link/20260224222542.3458677-4-neilb@ownmail.net
Signed-off-by: Christian Brauner <brauner@kernel.org>
| -rw-r--r-- | fs/namei.c | 27 |
1 files changed, 13 insertions, 14 deletions
diff --git a/fs/namei.c b/fs/namei.c index 6f595f58acfe..11c9a4a6c396 100644 --- a/fs/namei.c +++ b/fs/namei.c @@ -2893,20 +2893,6 @@ static int filename_parentat(int dfd, struct filename *name, return __filename_parentat(dfd, name, flags, parent, last, type, NULL); } -/** - * __start_dirop - begin a create or remove dirop, performing locking and lookup - * @parent: the dentry of the parent in which the operation will occur - * @name: a qstr holding the name within that parent - * @lookup_flags: intent and other lookup flags. - * @state: task state bitmask - * - * The lookup is performed and necessary locks are taken so that, on success, - * the returned dentry can be operated on safely. - * The qstr must already have the hash value calculated. - * - * Returns: a locked dentry, or an error. - * - */ static struct dentry *__start_dirop(struct dentry *parent, struct qstr *name, unsigned int lookup_flags, unsigned int state) @@ -2928,6 +2914,19 @@ static struct dentry *__start_dirop(struct dentry *parent, struct qstr *name, return dentry; } +/** + * start_dirop - begin a create or remove dirop, performing locking and lookup + * @parent: the dentry of the parent in which the operation will occur + * @name: a qstr holding the name within that parent + * @lookup_flags: intent and other lookup flags. + * + * The lookup is performed and necessary locks are taken so that, on success, + * the returned dentry can be operated on safely. + * The qstr must already have the hash value calculated. + * + * Returns: a locked dentry, or an error. + * + */ struct dentry *start_dirop(struct dentry *parent, struct qstr *name, unsigned int lookup_flags) { |