diff options
| author | Adrian Hunter <adrian.hunter@intel.com> | 2026-01-13 10:26:45 +0300 |
|---|---|---|
| committer | Alexandre Belloni <alexandre.belloni@bootlin.com> | 2026-01-14 19:21:09 +0300 |
| commit | 471895799c2f46688792e175ced936ffeb6cdf01 (patch) | |
| tree | 29ba26d1402b83319360bb4107087be7d7640bca | |
| parent | f0775157b9f9a28ae3eabc8d05b0bc52e8056c80 (diff) | |
| download | linux-471895799c2f46688792e175ced936ffeb6cdf01.tar.xz | |
i3c: master: Replace WARN_ON() with dev_err() in i3c_dev_free_ibi_locked()
IBI disable failures are not indicative of a software bug, so using
WARN_ON() is not appropriate. Replace these warnings with dev_err().
Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
Link: https://patch.msgid.link/20260113072702.16268-5-adrian.hunter@intel.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
| -rw-r--r-- | drivers/i3c/master.c | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c index d684a6b79960..71583cc4d197 100644 --- a/drivers/i3c/master.c +++ b/drivers/i3c/master.c @@ -3150,8 +3150,11 @@ void i3c_dev_free_ibi_locked(struct i3c_dev_desc *dev) if (!dev->ibi) return; - if (WARN_ON(dev->ibi->enabled)) - WARN_ON(i3c_dev_disable_ibi_locked(dev)); + if (dev->ibi->enabled) { + dev_err(&master->dev, "Freeing IBI that is still enabled\n"); + if (i3c_dev_disable_ibi_locked(dev)) + dev_err(&master->dev, "Failed to disable IBI before freeing\n"); + } master->ops->free_ibi(dev); |